Bug 136031

Summary:

Web Inspector: rename Inspector::TypeBuilder to Inspector::Protocol

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, commit-queue, graouts, gyuyoung.kim, joepeck, rakuco, sergio, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Brian Burg

Reported 2014-08-17 15:02:02 PDT

TypeBuilder is a an implementation detail, reflecting that protocol objects are shape-checked. Protocol makes it clearer that these objects are marshalled types sent to or received from the inspector protocol.

Attachments
Patch (501.18 KB, patch) 2014-08-17 21:18 PDT, Brian Burg	no flags	Details Formatted Diff Diff
Patch (501.23 KB, patch) 2014-08-17 22:48 PDT, Brian Burg	no flags	Details Formatted Diff Diff
Patch (501.38 KB, patch) 2014-08-25 07:21 PDT, Brian Burg	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-08-17 15:02:14 PDT

<rdar://problem/18044560>

Brian Burg

Comment 2 2014-08-17 21:18:56 PDT

Created attachment 236740 [details] Patch

Brian Burg

Comment 3 2014-08-17 22:48:37 PDT

Created attachment 236741 [details] Patch

Timothy Hatcher

Comment 4 2014-08-18 23:50:52 PDT

Comment on attachment 236741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236741&action=review Rubber-stamp here assuming you can get it applying and building in EWS. > Source/JavaScriptCore/ChangeLog:9 > + Rename TypeBuilder namespace to Protocol. Disambiguate where > + necessary. Also rename InspectorTypeBuilder to ProtocolTypes. Yay!

Brian Burg

Comment 5 2014-08-25 07:21:42 PDT

Created attachment 237083 [details] Patch

WebKit Commit Bot

Comment 6 2014-08-25 10:30:30 PDT

Attachment 237083 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_dispatcher_header.py:52: [BackendDispatcherHeaderGenerator.generate_output] Instance of 'BackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:54: whitespace before ']' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:67: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:278: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:301: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:45: [ProtocolTypesHeaderGenerator.output_filename] Instance of 'ProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:48: [ProtocolTypesHeaderGenerator.generate_output] Instance of 'ProtocolTypesHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:49: [ProtocolTypesHeaderGenerator.generate_output] Instance of 'ProtocolTypesHeaderGenerator' has no 'calculate_types_requiring_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:57: [ProtocolTypesHeaderGenerator.generate_output] Instance of 'ProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:60: [ProtocolTypesHeaderGenerator.generate_output] Instance of 'ProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:61: [ProtocolTypesHeaderGenerator.generate_output] Instance of 'ProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:67: [ProtocolTypesHeaderGenerator.generate_output] Instance of 'ProtocolTypesHeaderGenerator' has no '_input_filepath' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:76: [ProtocolTypesHeaderGenerator.generate_output] Instance of 'ProtocolTypesHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:249: [ProtocolTypesHeaderGenerator._generate_struct_for_enum_type] Instance of 'ProtocolTypesHeaderGenerator' has no 'encoding_for_enum_value' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:275: [ProtocolTypesHeaderGenerator._generate_builder_setter_for_member] Instance of 'ProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:298: [ProtocolTypesHeaderGenerator._generate_unchecked_setter_for_member] Instance of 'ProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:319: [ProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits] Instance of 'ProtocolTypesHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:320: [ProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits.<lambda>] Instance of 'ProtocolTypesHeaderGenerator' has no 'type_needs_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py:332: [ProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits] Instance of 'ProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:114: The parameter name "pseudoIdMatches" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/inspector/InspectorProtocolTypes.h:43: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:55: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:115: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:134: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:150: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:44: [ProtocolTypesImplementationGenerator.output_filename] Instance of 'ProtocolTypesImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:47: [ProtocolTypesImplementationGenerator.generate_output] Instance of 'ProtocolTypesImplementationGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:48: [ProtocolTypesImplementationGenerator.generate_output] Instance of 'ProtocolTypesImplementationGenerator' has no 'calculate_types_requiring_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:53: [ProtocolTypesImplementationGenerator.generate_output] Instance of 'ProtocolTypesImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:55: [ProtocolTypesImplementationGenerator.generate_output] Instance of 'ProtocolTypesImplementationGenerator' has no '_input_filepath' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:59: [ProtocolTypesImplementationGenerator.generate_output] Instance of 'ProtocolTypesImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:74: [ProtocolTypesImplementationGenerator._generate_enum_mapping] Instance of 'ProtocolTypesImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:78: [ProtocolTypesImplementationGenerator._generate_enum_mapping] Instance of 'ProtocolTypesImplementationGenerator' has no 'assigned_enum_values' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:89: [ProtocolTypesImplementationGenerator._generate_open_field_names] Instance of 'ProtocolTypesImplementationGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py:99: [ProtocolTypesImplementationGenerator._generate_builders_for_domain.<lambda>] Instance of 'ProtocolTypesImplementationGenerator' has no 'type_needs_shape_assertions' member [pylint/E1101] [5] ERROR: Source/WebCore/inspector/InspectorReplayAgent.h:107: The parameter name "segmentState" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 36 in 87 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brian Burg

Comment 7 2014-08-25 11:39:37 PDT

Committed r172930: <http://trac.webkit.org/changeset/172930>

Note You need to log in before you can comment on or make changes to this bug.