Bug 136017

Summary: [GTK] build fails with error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’
Product: WebKit Reporter: Byungseon Shin <sun.shin>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: berto, cgarcia, commit-queue, gns, gyuyoung.kim, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Byungseon Shin 2014-08-16 03:01:28 PDT
./Tools/Scripts/build-webkit --gtk fails with this error:

../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h: In static member function ‘static std::unique_ptr<WebKit::PageClientImpl> WebKit::PageClientImpl::create(GtkWidget*)’:
../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:54:77: error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’
         return std::unique_ptr<PageClientImpl>(new PageClientImpl(viewWidget));
../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:46:7: note:   because the following virtual functions are pure within ‘WebKit::PageClientImpl’:
 class PageClientImpl : public PageClient
In file included from ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:33:0,
                 from ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:29:
../../Source/WebKit2/UIProcess/PageClient.h:306:18: note: 	virtual void WebKit::PageClient::didFirstVisuallyNonEmptyLayoutForMainFrame()
     virtual void didFirstVisuallyNonEmptyLayoutForMainFrame() = 0;
../../Source/WebKit2/UIProcess/PageClient.h:307:18: note: 	virtual void WebKit::PageClient::didFinishLoadForMainFrame()
     virtual void didFinishLoadForMainFrame() = 0;
Comment 1 Byungseon Shin 2014-08-16 03:06:33 PDT
Created attachment 236709 [details]
Comment 2 Byungseon Shin 2014-08-16 03:07:59 PDT
Created attachment 236710 [details]
Comment 3 WebKit Commit Bot 2014-08-16 03:08:17 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Gyuyoung Kim 2014-08-16 06:53:12 PDT
Comment on attachment 236710 [details]

rs=me to fix build break on gtk port.
Comment 5 Gyuyoung Kim 2014-08-16 07:02:29 PDT
For the record, r172635 caused this break.

Comment 6 WebKit Commit Bot 2014-08-16 07:26:30 PDT
Comment on attachment 236710 [details]

Clearing flags on attachment: 236710

Committed r172690: <http://trac.webkit.org/changeset/172690>
Comment 7 WebKit Commit Bot 2014-08-16 07:26:34 PDT
All reviewed patches have been landed.  Closing bug.