Summary: | [GTK] build fails with error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’ | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Byungseon(Sun) Shin <sun.shin> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, cgarcia, commit-queue, gustavo, gyuyoung.kim, mrobinson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Byungseon(Sun) Shin
2014-08-16 03:01:28 PDT
Created attachment 236709 [details]
Patch
Created attachment 236710 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 236710 [details]
Patch
rs=me to fix build break on gtk port.
For the record, r172635 caused this break. http://trac.webkit.org/changeset/172635. Comment on attachment 236710 [details] Patch Clearing flags on attachment: 236710 Committed r172690: <http://trac.webkit.org/changeset/172690> All reviewed patches have been landed. Closing bug. |