Bug 13601
| Summary: | plugInViewWithArguments: called with truncated argument dict when baseURL is nil | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | James G. Speth <speth> |
| Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, rniwa |
| Priority: | P2 | ||
| Version: | 523.x (Safari 3) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
James G. Speth
when WebKit plugins are created by WebFrameBridge, if their base URL is nil, the plugInViewWithArguments: method is called with an argument dictionary that is missing some values. most noticeably, WebPlugInContainingElementKey is missing.
see the comment at WebFrameBridge.mm:460:
// URL might be nil, so add it last
however, it's not last anymore, so when it is nil, all the values after it in the call to dictionaryWithObjectsAndKeys: are ignored. so, we need to pay attention to the comment and put WebPlugInBaseURLKey last, or create the dictionary some other way.
I'll make a test case and patch for it, unless someone beats me to it, but i wanted get this in bugzilla before I forget again.
also, this problem exists both places that dictionary could be created:
viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:
pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:
so we should fix them both, or have them call a common method to create the dictionary.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Webkit plugins support is gone and also "WebFrameBridge.mm" is also removed in bug 17640.
Can this be marked as "RESOLVED WONTFIX"? Thanks!