Bug 136007

Summary:

[Win] Link to static VS2013 runtime library

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

bfulgham, ossy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	dino: review+

Description Brent Fulgham 2014-08-15 16:55:58 PDT

This bug switches our build from using the VS2013 DLL to linking to the static library.

Comment 1 Brent Fulgham 2014-08-15 16:56:18 PDT

<rdar://problem/18037766>

Comment 2 Brent Fulgham 2014-08-15 16:58:21 PDT

Created attachment 236693 [details]
Patch

Comment 3 Brent Fulgham 2014-08-15 17:42:50 PDT

Committed r172661: <http://trac.webkit.org/changeset/172661>

Comment 4 Csaba Osztrogonác 2014-08-16 11:01:22 PDT

(In reply to comment #3)
> Committed r172661: <http://trac.webkit.org/changeset/172661>

FYI: It broke the build on the Apple Windows buildbots and EWS

Comment 5 Brent Fulgham 2014-08-18 08:48:31 PDT

(In reply to comment #4)
> (In reply to comment #3)
> > Committed r172661: <http://trac.webkit.org/changeset/172661>
> 
> FYI: It broke the build on the Apple Windows buildbots and EWS

This is fixed. We needed to update the WebKitSystemInterface.lib to a version that statically linked to VS2013 runtime.