Bug 136000

Summary: Use modern for loop instead of iterators in SharedBufferCF.cpp
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: WebCore Misc.Assignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, psolanki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch kling: review+

Pratik Solanki
Reported 2014-08-15 16:01:01 PDT
SharedBufferCF.cpp could use some for loop updates.
Attachments
Patch (2.64 KB, patch)
2014-08-15 16:02 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
Patch (2.64 KB, patch)
2014-08-15 16:07 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
Patch (3.09 KB, patch)
2014-08-18 12:09 PDT, Pratik Solanki 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2014-08-15 16:02:32 PDT
Created attachment 236685 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-15 16:05:06 PDT
Attachment 236685 [details] did not pass style-queue: ERROR: Source/WebCore/platform/cf/SharedBufferCF.cpp:160: Missing space before ( in for( [whitespace/parens] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pratik Solanki
Comment 3 2014-08-15 16:07:59 PDT
Created attachment 236687 [details] Patch
Alexey Proskuryakov
Comment 4 2014-08-15 21:02:45 PDT
Comment on attachment 236687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236687&action=review > Source/WebCore/platform/cf/SharedBufferCF.cpp:157 > + for (auto cfData : m_dataArray) { This makes the code slightly slower, as it makes a new RetainPtr which churns refcount.
Andreas Kling
Comment 5 2014-08-15 21:08:49 PDT
Comment on attachment 236687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236687&action=review >> Source/WebCore/platform/cf/SharedBufferCF.cpp:157 >> + for (auto cfData : m_dataArray) { > > This makes the code slightly slower, as it makes a new RetainPtr which churns refcount. Using auto& would avoid that.
Pratik Solanki
Comment 6 2014-08-18 12:09:00 PDT
Created attachment 236773 [details] Patch
Pratik Solanki
Comment 7 2014-08-18 16:23:20 PDT
Committed r172735: <http://trac.webkit.org/changeset/172735>
Note You need to log in before you can comment on or make changes to this bug.