Bug 136000

Summary: Use modern for loop instead of iterators in SharedBufferCF.cpp
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: WebCore Misc.Assignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, psolanki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch kling: review+

Description Pratik Solanki 2014-08-15 16:01:01 PDT
SharedBufferCF.cpp could use some for loop updates.
Comment 1 Pratik Solanki 2014-08-15 16:02:32 PDT
Created attachment 236685 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-15 16:05:06 PDT
Attachment 236685 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/cf/SharedBufferCF.cpp:160:  Missing space before ( in for(  [whitespace/parens] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pratik Solanki 2014-08-15 16:07:59 PDT
Created attachment 236687 [details]
Patch
Comment 4 Alexey Proskuryakov 2014-08-15 21:02:45 PDT
Comment on attachment 236687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236687&action=review

> Source/WebCore/platform/cf/SharedBufferCF.cpp:157
> +    for (auto cfData : m_dataArray) {

This makes the code slightly slower, as it makes a new RetainPtr which churns refcount.
Comment 5 Andreas Kling 2014-08-15 21:08:49 PDT
Comment on attachment 236687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236687&action=review

>> Source/WebCore/platform/cf/SharedBufferCF.cpp:157
>> +    for (auto cfData : m_dataArray) {
> 
> This makes the code slightly slower, as it makes a new RetainPtr which churns refcount.

Using auto& would avoid that.
Comment 6 Pratik Solanki 2014-08-18 12:09:00 PDT
Created attachment 236773 [details]
Patch
Comment 7 Pratik Solanki 2014-08-18 16:23:20 PDT
Committed r172735: <http://trac.webkit.org/changeset/172735>