| Summary: | REGRESSION (WebKit2 Gestures): White flash when swiping back to cnn.com's homepage from an article | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, kdecker, mitz, sam, simon.fraser | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-08-14 14:03:29 PDT
Created attachment 236618 [details]
patch
Comment on attachment 236618 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236618&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:3617 > +- (void)_removeNavigationGestureSnapshot > +{ > + if (_data->_gestureController) > + _data->_gestureController->removeSwipeSnapshot(); > +} swipe vs. gesture: can we use the same terminology everywhere? (In reply to comment #2) > (From update of attachment 236618 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236618&action=review > > > Source/WebKit2/UIProcess/API/mac/WKView.mm:3617 > > +- (void)_removeNavigationGestureSnapshot > > +{ > > + if (_data->_gestureController) > > + _data->_gestureController->removeSwipeSnapshot(); > > +} > > swipe vs. gesture: can we use the same terminology everywhere? I don't know how it happened (probably because we spent more time on naming for the API), but the API/view level is all about "navigation gestures" and the internals are all about "swipe" (though the SPI doesn't follow this rule). We can fix it, but for now I'm just going to follow along. |