Bug 135928

Summary:

import-w3c-tests doesn't import .svg support files

Product:

WebKit

Reporter:

Rebecca Hauck <rhauck>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bjonesbe, commit-queue, glenn

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for the bug	bjonesbe: review+, bjonesbe: commit-queue-
fixed changelog typo	none
fixed nit.	none

Description Rebecca Hauck 2014-08-13 19:25:04 PDT

When importing the CSS Shapes W3C test suite, I discovered that no support/*.svg files were imported.  Should be an easy fix as I believe I'm explicitly listing file extensions somewhere and probably just forgot .svg in this context.

Comment 1 Rebecca Hauck 2014-08-19 18:31:16 PDT

Created attachment 236843 [details]
Patch for the bug

Comment 2 Bem Jones-Bey 2014-08-20 10:11:46 PDT

Comment on attachment 236843 [details]
Patch for the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=236843&action=review

r=me, but you should fix the typo in the ChangeLog before landing.

> Tools/ChangeLog:9
> +        files with an xml mimetype as convertible tests,.which

s/,./, /

Comment 3 Rebecca Hauck 2014-08-20 10:43:09 PDT

Created attachment 236877 [details]
fixed changelog typo

Comment 4 Rebecca Hauck 2014-08-20 10:53:07 PDT

Created attachment 236880 [details]
fixed nit.

Comment 5 WebKit Commit Bot 2014-08-20 12:10:56 PDT

Comment on attachment 236880 [details]
fixed nit.

Clearing flags on attachment: 236880

Committed r172803: <http://trac.webkit.org/changeset/172803>

Comment 6 WebKit Commit Bot 2014-08-20 12:10:59 PDT

All reviewed patches have been landed.  Closing bug.