Bug 135913

Summary:

Fix a memory leak in TypeSet

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2014-08-13 16:18:17 PDT

There is currently a memory leak with the member variable: m_structureHistory. Fix it.

Comment 1 Saam Barati 2014-08-20 10:57:48 PDT

Created attachment 236882 [details]
patch

Fixes the memory leak.

Comment 2 WebKit Commit Bot 2014-08-20 12:28:02 PDT

Comment on attachment 236882 [details]
patch

Clearing flags on attachment: 236882

Committed r172804: <http://trac.webkit.org/changeset/172804>

Comment 3 WebKit Commit Bot 2014-08-20 12:28:04 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Geoffrey Garen 2014-08-20 13:46:56 PDT

Comment on attachment 236882 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236882&action=review

> Source/JavaScriptCore/runtime/TypeSet.cpp:120
> +        RefPtr<StructureShape> shape = m_structureHistory.at(i);

Can you use bracket access instead of .at() in all this code?