Bug 135899

Summary: Rename HighFidelityTypeProfiling variables for more clarity
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, burg, commit-queue, fpizlo, ggaren, gyuyoung.kim, joepeck, rakuco, sergio, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
ggaren: review+, commit-queue: commit-queue-
patch none

Description Saam Barati 2014-08-13 13:32:09 PDT 
Some variables are named using HighFidelity__, but it would be more readable and understandable for these variables to be named TypeProfiler__.
Comment 1 Saam Barati 2014-08-19 17:59:46 PDT 
Created attachment 236840 [details]
patch

Massive renaming job.
Comment 2 WebKit Commit Bot 2014-08-19 18:02:44 PDT 
Attachment 236840 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/TypeProfilerLog.h:92:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:58:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:94:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 3 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2014-08-19 18:05:45 PDT 
Created attachment 236841 [details]
patch

Fix above style bugs.
Comment 4 Geoffrey Garen 2014-08-20 13:48:03 PDT 
Comment on attachment 236841 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2014-08-20 14:03:53 PDT 
Comment on attachment 236841 [details]
patch

Rejecting attachment 236841 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 236841, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
g file Source/JavaScriptCore/runtime/TypeProfilerLog.cpp
patching file Source/JavaScriptCore/runtime/TypeProfilerLog.h
patching file Source/JavaScriptCore/runtime/VM.cpp
patching file Source/JavaScriptCore/runtime/VM.h
patching file Source/WebInspectorUI/ChangeLog
patching file Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6029360024780800
Comment 6 Saam Barati 2014-08-20 17:23:07 PDT 
Created attachment 236903 [details]
patch

Fixed conflict.
Comment 7 Geoffrey Garen 2014-08-20 17:25:17 PDT 
Comment on attachment 236903 [details]
patch

r=me
Comment 8 WebKit Commit Bot 2014-08-20 18:03:36 PDT 
Comment on attachment 236903 [details]
patch

Clearing flags on attachment: 236903

Committed r172820: <http://trac.webkit.org/changeset/172820>
Comment 9 WebKit Commit Bot 2014-08-20 18:03:42 PDT 
All reviewed patches have been landed.  Closing bug.