Bug 135899

Summary:

Rename HighFidelityTypeProfiling variables for more clarity

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, burg, commit-queue, fpizlo, ggaren, gyuyoung.kim, joepeck, rakuco, sergio, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	ggaren: review+, commit-queue: commit-queue-
patch	none

Saam Barati

Reported 2014-08-13 13:32:09 PDT

Some variables are named using HighFidelity__, but it would be more readable and understandable for these variables to be named TypeProfiler__.

Attachments
patch (153.29 KB, patch) 2014-08-19 17:59 PDT, Saam Barati	no flags	Details Formatted Diff Diff
patch (153.29 KB, patch) 2014-08-19 18:05 PDT, Saam Barati	ggaren: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
patch (163.99 KB, patch) 2014-08-20 17:23 PDT, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2014-08-19 17:59:46 PDT

Created attachment 236840 [details] patch Massive renaming job.

WebKit Commit Bot

Comment 2 2014-08-19 18:02:44 PDT

Attachment 236840 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/TypeProfilerLog.h:92: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:58: Missing space after , [whitespace/comma] [3] ERROR: Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:94: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 3 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.

Saam Barati

Comment 3 2014-08-19 18:05:45 PDT

Created attachment 236841 [details] patch Fix above style bugs.

Geoffrey Garen

Comment 4 2014-08-20 13:48:03 PDT

Comment on attachment 236841 [details] patch r=me

WebKit Commit Bot

Comment 5 2014-08-20 14:03:53 PDT

Comment on attachment 236841 [details] patch Rejecting attachment 236841 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 236841, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/JavaScriptCore/runtime/TypeProfilerLog.cpp patching file Source/JavaScriptCore/runtime/TypeProfilerLog.h patching file Source/JavaScriptCore/runtime/VM.cpp patching file Source/JavaScriptCore/runtime/VM.h patching file Source/WebInspectorUI/ChangeLog patching file Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6029360024780800

Saam Barati

Comment 6 2014-08-20 17:23:07 PDT

Created attachment 236903 [details] patch Fixed conflict.

Geoffrey Garen

Comment 7 2014-08-20 17:25:17 PDT

Comment on attachment 236903 [details] patch r=me

WebKit Commit Bot

Comment 8 2014-08-20 18:03:36 PDT

Comment on attachment 236903 [details] patch Clearing flags on attachment: 236903 Committed r172820: <http://trac.webkit.org/changeset/172820>

WebKit Commit Bot

Comment 9 2014-08-20 18:03:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.