Bug 13587

Summary: WebKitQt build fails if MacPorts has pcre installed.
Product: WebKit Reporter: Erik L. Bunce <elbunce>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
This removes the depenency on MacPorts mrowe: review+

Erik L. Bunce
Reported 2007-05-04 07:20:41 PDT
WebKitQt qmake files have a dependency on MacPorts that can break the build if the user has a MacPorts install of pcre. /regexp.o ../../../JavaScriptCore/kjs/regexp.cpp ../../../JavaScriptCore/kjs/regexp.cpp: In constructor 'KJS::RegExp::RegExp(const KJS::UString&, int)': ../../../JavaScriptCore/kjs/regexp.cpp:51: error: cannot convert 'const uint16_t*' to 'const char*' for argument '1' to 'pcre* pcre_compile(const char*, int, const char**, int*, const unsigned char*)' ../../../JavaScriptCore/kjs/regexp.cpp:56: error: cannot convert 'const uint16_t*' to 'const char*' for argument '1' to 'pcre* pcre_compile(const char*, int, const char**, int*, const unsigned char*)' ../../../JavaScriptCore/kjs/regexp.cpp: In member function 'KJS::UString KJS::RegExp::match(const KJS::UString&, int, int*, int**)': ../../../JavaScriptCore/kjs/regexp.cpp:139: error: cannot convert 'const uint16_t*' to 'const char*' for argument '3' to 'int pcre_exec(const pcre*, const pcre_extra*, const char*, int, int, int, int*, int)' make[1]: *** [tmp/regexp.o] Error 1 make: *** [sub-WebCore-make_default-ordered] Error 2
Attachments
This removes the depenency on MacPorts (1.75 KB, patch)
2007-05-04 07:22 PDT, Erik L. Bunce 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Erik L. Bunce
Comment 1 2007-05-04 07:22:25 PDT
Created attachment 14342 [details] This removes the depenency on MacPorts This patch removes the dependency on MacPorts and fixes the build.
Mark Rowe (bdash)
Comment 2 2007-05-05 09:59:39 PDT
Comment on attachment 14342 [details] This removes the depenency on MacPorts r=me
Mark Rowe (bdash)
Comment 3 2007-05-06 19:58:10 PDT
Landed in r21277.
Note You need to log in before you can comment on or make changes to this bug.