Summary: | Media document sends incorrect referer header | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Carlson
2014-08-12 06:50:55 PDT
Created attachment 236445 [details]
Proposed patch.
Comment on attachment 236445 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=236445&action=review > Source/WebCore/html/MediaDocument.cpp:148 > + if (frame) > + m_referrer = frame->loader().outgoingReferrer(); The Document class doesn't stash it's referrer; it fetches it from the loader each time it's requested. I'm concerned that there may be some situation where we don't have a frame at creation time, but get one later. (Though maybe it's something which Document has to worry about but not MediaDocument.) Also, if we do decide to stash the outgoing referrer, we should probably name the variable m_outgoingReferrer. Other than that nit, r=me. Committed r172523 : https://trac.webkit.org/r172523 |