Summary: | ASSERTION FAILED: m_intervalBegin.isFinite() in WebCore::SVGSMILElement::notifyDependentsIntervalChanged | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Renata Hodovan <rhodovan.u-szeged> | ||||
Component: | SVG | Assignee: | Renata Hodovan <rhodovan.u-szeged> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, dino, d-r, fmalita, gyuyoung.kim, pdr, schenney, sergio, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 116980 | ||||||
Attachments: |
|
Description
Renata Hodovan
2014-08-12 05:46:49 PDT
Created attachment 236442 [details]
Proposed patch
Comment on attachment 236442 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=236442&action=review > Source/WebCore/svg/animation/SVGSMILElement.cpp:308 > + if (!ok || !SMILTime(result).isFinite()) Seems fine, but don’t we also want to reject negative numbers? Also, I see the code to construct an SMILTime rejects NaN. What prevents toDouble from returning NaN? Comment on attachment 236442 [details] Proposed patch Clearing flags on attachment: 236442 Committed r172496: <http://trac.webkit.org/changeset/172496> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > (From update of attachment 236442 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236442&action=review > > > Source/WebCore/svg/animation/SVGSMILElement.cpp:308 > > + if (!ok || !SMILTime(result).isFinite()) > > Seems fine, but don’t we also want to reject negative numbers? Negative values are valid for representing animation offsets: http://www.w3.org/TR/SVG/animate.html#OffsetValueSyntax > Also, I see the code to construct an SMILTime rejects NaN. What prevents toDouble from returning NaN? If the given value is not a number than toDouble sets the |ok| flag to false to indicate that something went wrong and the result will be set to unresolved. |