Bug 135818

Summary: RenderObject::repaintUsingContainer should take repaint container as reference.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: NEW    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 135817    
Attachments:
Description Flags
Patch simon.fraser: review+, zalan: commit-queue-

alan
Reported 2014-08-11 16:00:48 PDT
subtask of bug 135817
Attachments
Patch (19.54 KB, patch)
2014-08-11 16:12 PDT, alan 		simon.fraser: review+
zalan: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-08-11 16:12:53 PDT
Created attachment 236411 [details] Patch
Darin Adler
Comment 2 2014-08-11 22:09:28 PDT
Comment on attachment 236411 [details] Patch This seems worse than the old version. All those null checks at all the call sites are messy.
alan
Comment 3 2014-08-15 20:56:21 PDT
Comment on attachment 236411 [details] Patch (In reply to comment #2) > (From update of attachment 236411 [details]) > This seems worse than the old version. All those null checks at all the call sites are messy. Yes, they are! This is an incremental change. see Changlog entry: "This is in preparation to ensure that we always pass a valid repaint container to repaint functions. (tracked here webkit.org/b/135817). This changeset has explicit view() calls which are going to be removed once containerForRepaint() starts returning container reference." My plan is to enforce containerForRepaint() to return a reference. There's a chance that it's not possible without some major changes so I decided to do it incrementally. However, I wasn't planning to commit these intermediate changes until after the goal is met. (so those null checks should never land on trunk.) I should have been more vocal about it in the bug description.
Note You need to log in before you can comment on or make changes to this bug.