Bug 135815

Summary:

update-webkit should not check for the presence of Apple’s Internal directory

Product:

WebKit

Reporter:

mitz

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, darin, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
I. Add --[no-]auxiliary-libs option	none
I. Add --[no-]auxiliary-libs option	thorton: review+
II. Add --[no-]internal option	thorton: review+
III. Remove code that deals with ../Internal	thorton: review+

mitz

Reported 2014-08-11 14:22:00 PDT

The update-webkit script behaves differently in the presence of an Internal directory next to the root of the WebKit source tree.

Attachments
I. Add --[no-]auxiliary-libs option (2.21 KB, patch) 2014-08-11 14:25 PDT, mitz	no flags	Details Formatted Diff Diff
I. Add --[no-]auxiliary-libs option (2.23 KB, patch) 2014-08-11 14:27 PDT, mitz	thorton: review+	Details Formatted Diff Diff
II. Add --[no-]internal option (6.08 KB, patch) 2014-08-18 13:58 PDT, mitz	thorton: review+	Details Formatted Diff Diff
III. Remove code that deals with ../Internal (2.25 KB, patch) 2014-08-19 15:10 PDT, mitz	thorton: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2014-08-11 14:25:01 PDT

Created attachment 236400 [details] I. Add --[no-]auxiliary-libs option

mitz

Comment 2 2014-08-11 14:27:19 PDT

Created attachment 236401 [details] I. Add --[no-]auxiliary-libs option

mitz

Comment 3 2014-08-11 16:41:53 PDT

Committed attachment 236401 [details] as http://trac.webkit.org/r172419.

Daniel Bates

Comment 4 2014-08-13 21:51:19 PDT

Marking Resolved Fixed since the patch was committed in <http://trac.webkit.org/r172419> per comment 3.

mitz

Comment 5 2014-08-13 21:51:42 PDT

I was just getting started.

mitz

Comment 6 2014-08-18 13:58:46 PDT

Created attachment 236783 [details] II. Add --[no-]internal option

Tim Horton

Comment 7 2014-08-18 14:18:39 PDT

Comment on attachment 236783 [details] II. Add --[no-]internal option View in context: https://bugs.webkit.org/attachment.cgi?id=236783&action=review > Tools/Scripts/update-webkit:52 > +# FIXME: http://webkit.org/b/135815 update-webkit should not check for the presence of Appleâs Internal directory It may be best not to use smart quotes in source.

mitz

Comment 8 2014-08-18 14:45:03 PDT

Committed attachment 236783 [details] as http://trac.webkit.org/r172728.

mitz

Comment 9 2014-08-19 15:10:10 PDT

Created attachment 236826 [details] III. Remove code that deals with ../Internal

mitz

Comment 10 2014-08-19 20:02:40 PDT

Fixed in http://trac.webkit.org/r172795.

Note You need to log in before you can comment on or make changes to this bug.