Bug 135815

Summary: update-webkit should not check for the presence of Apple’s Internal directory
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
I. Add --[no-]auxiliary-libs option
none
I. Add --[no-]auxiliary-libs option
thorton: review+
II. Add --[no-]internal option
thorton: review+
III. Remove code that deals with ../Internal thorton: review+

Description mitz 2014-08-11 14:22:00 PDT
The update-webkit script behaves differently in the presence of an Internal directory next to the root of the WebKit source tree.
Comment 1 mitz 2014-08-11 14:25:01 PDT
Created attachment 236400 [details]
I. Add --[no-]auxiliary-libs option
Comment 2 mitz 2014-08-11 14:27:19 PDT
Created attachment 236401 [details]
I. Add --[no-]auxiliary-libs option
Comment 3 mitz 2014-08-11 16:41:53 PDT
Committed attachment 236401 [details] as http://trac.webkit.org/r172419.
Comment 4 Daniel Bates 2014-08-13 21:51:19 PDT
Marking Resolved Fixed since the patch was committed in <http://trac.webkit.org/r172419> per comment 3.
Comment 5 mitz 2014-08-13 21:51:42 PDT
I was just getting started.
Comment 6 mitz 2014-08-18 13:58:46 PDT
Created attachment 236783 [details]
II. Add --[no-]internal option
Comment 7 Tim Horton 2014-08-18 14:18:39 PDT
Comment on attachment 236783 [details]
II. Add --[no-]internal option

View in context: https://bugs.webkit.org/attachment.cgi?id=236783&action=review

> Tools/Scripts/update-webkit:52
> +# FIXME: http://webkit.org/b/135815 update-webkit should not check for the presence of Appleâs Internal directory

It may be best not to use smart quotes in source.
Comment 8 mitz 2014-08-18 14:45:03 PDT
Committed attachment 236783 [details] as http://trac.webkit.org/r172728.
Comment 9 mitz 2014-08-19 15:10:10 PDT
Created attachment 236826 [details]
III. Remove code that deals with ../Internal
Comment 10 mitz 2014-08-19 20:02:40 PDT
Fixed in http://trac.webkit.org/r172795.