Bug 135799

Summary: Pass inherited style only when resolving tree style
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, commit-queue, d-r, esprehn+autocc, fmalita, gyuyoung.kim, kangil.han, pdr, rniwa, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
none
patch 2
kling: review+
patch 3 none

Description Antti Koivisto 2014-08-11 07:14:15 PDT
No need to pass around the style parent element.
Comment 1 Antti Koivisto 2014-08-11 07:19:02 PDT
Created attachment 236366 [details]
patch
Comment 2 Build Bot 2014-08-11 08:38:10 PDT
Comment on attachment 236366 [details]
patch

Attachment 236366 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5788940975996928

New failing tests:
svg/custom/outer-svg-unknown-feature.svg
Comment 3 Build Bot 2014-08-11 08:38:12 PDT
Created attachment 236369 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-08-11 09:23:50 PDT
Comment on attachment 236366 [details]
patch

Attachment 236366 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6383279624159232

New failing tests:
svg/custom/outer-svg-unknown-feature.svg
Comment 5 Build Bot 2014-08-11 09:23:53 PDT
Created attachment 236372 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-08-11 09:40:24 PDT
Comment on attachment 236366 [details]
patch

Attachment 236366 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6350442451697664

New failing tests:
svg/custom/outer-svg-unknown-feature.svg
Comment 7 Build Bot 2014-08-11 09:40:28 PDT
Created attachment 236374 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Antti Koivisto 2014-08-11 11:40:48 PDT
Created attachment 236387 [details]
patch 2
Comment 9 Andreas Kling 2014-08-11 11:53:11 PDT
Comment on attachment 236387 [details]
patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=236387&action=review

Solid LVR; r=me

> Source/WebCore/style/StyleResolveTree.cpp:68
> +    RenderTreePosition(RenderView&);
>      RenderTreePosition(RenderElement* parent);

These should be explicit.
Comment 10 Antti Koivisto 2014-08-11 12:29:53 PDT
Created attachment 236392 [details]
patch 3
Comment 11 Antti Koivisto 2014-08-11 13:43:00 PDT
https://trac.webkit.org/r172409