Bug 135799

Summary:

Pass inherited style only when resolving tree style

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cmarcelo, commit-queue, d-r, esprehn+autocc, fmalita, gyuyoung.kim, kangil.han, pdr, rniwa, schenney, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion	none
patch 2	kling: review+
patch 3	none

Antti Koivisto

Reported 2014-08-11 07:14:15 PDT

No need to pass around the style parent element.

Attachments
patch (deleted) 2014-08-11 07:19 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (501.91 KB, application/zip) 2014-08-11 08:38 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (487.76 KB, application/zip) 2014-08-11 09:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (501.12 KB, application/zip) 2014-08-11 09:40 PDT, Build Bot	no flags	Details
patch 2 (28.06 KB, patch) 2014-08-11 11:40 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
patch 3 (28.86 KB, patch) 2014-08-11 12:29 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2014-08-11 07:19:02 PDT

Created attachment 236366 [details] patch

Build Bot

Comment 2 2014-08-11 08:38:10 PDT

Comment on attachment 236366 [details] patch Attachment 236366 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5788940975996928 New failing tests: svg/custom/outer-svg-unknown-feature.svg

Build Bot

Comment 3 2014-08-11 08:38:12 PDT

Created attachment 236369 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-08-11 09:23:50 PDT

Comment on attachment 236366 [details] patch Attachment 236366 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6383279624159232 New failing tests: svg/custom/outer-svg-unknown-feature.svg

Build Bot

Comment 5 2014-08-11 09:23:53 PDT

Created attachment 236372 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-08-11 09:40:24 PDT

Comment on attachment 236366 [details] patch Attachment 236366 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6350442451697664 New failing tests: svg/custom/outer-svg-unknown-feature.svg

Build Bot

Comment 7 2014-08-11 09:40:28 PDT

Created attachment 236374 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Antti Koivisto

Comment 8 2014-08-11 11:40:48 PDT

Created attachment 236387 [details] patch 2

Andreas Kling

Comment 9 2014-08-11 11:53:11 PDT

Comment on attachment 236387 [details] patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=236387&action=review Solid LVR; r=me > Source/WebCore/style/StyleResolveTree.cpp:68 > + RenderTreePosition(RenderView&); > RenderTreePosition(RenderElement* parent); These should be explicit.

Antti Koivisto

Comment 10 2014-08-11 12:29:53 PDT

Created attachment 236392 [details] patch 3

Antti Koivisto

Comment 11 2014-08-11 13:43:00 PDT

https://trac.webkit.org/r172409

Note You need to log in before you can comment on or make changes to this bug.