| Summary: | [GTK] Child processes should be installed in a versioned directory | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | berto, bunhere, commit-queue, gyuyoung.kim, rakuco, sergio | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2014-08-08 02:25:05 PDT
Created attachment 236273 [details]
Patch
Committed r172376: <http://trac.webkit.org/changeset/172376> I noticed we have a bit of a problem here, we are installing the
binaries in ${libexec}/webkitgtk-4.0/ (see LIBEXEC_INSTALL_DIR in
OptionsGTK.cmake) but we are also installing the injected bundle in
${libdir}/webkit2gtk-4.0/ (see PlatformGTK.cmake).
I suggest that we use webkit2gtk-4.0 in both cases.
(In reply to comment #3) > I noticed we have a bit of a problem here, we are installing the > binaries in ${libexec}/webkitgtk-4.0/ (see LIBEXEC_INSTALL_DIR in > OptionsGTK.cmake) but we are also installing the injected bundle in > ${libdir}/webkit2gtk-4.0/ (see PlatformGTK.cmake). > > I suggest that we use webkit2gtk-4.0 in both cases. You are right, if we use ${libexec}/webkitgtk-4.0/ we should probably add another directory ${libexec}/webkitgtk-4.0/webkit2 or something like that, similar to what we do for header files. But it's very unlikely that we add another wk API layer that has extensions and processes, so it's simpler to use webkit2gtk-4.0 directly. Please, file a new bug report for this. |