|Summary:||Change of default colors for CSS2.1 system colors|
|Product:||WebKit||Reporter:||Peter Müller <pm>|
|Component:||Layout and Rendering||Assignee:||Nobody <webkit-unassigned>|
|Version:||523.x (Safari 3)|
|OS:||OS X 10.4|
Description Peter Müller 2007-05-03 08:59:22 PDT
This patch changes the hardcoded colors from the current values which cause color conflicts on Menu, Info and Highlight items, effectively making these items unreadable because background and text color are identical. While this patch does not implement the fetching of colors from the OS via AppKit or similar, it does provide some sane color values based partially on Aqua and adaption to how the system colors degrade relative to the main colors on MS Windows. A testcase is available at http://fumle.dk/colortest.php where the topmost link switches the styling between using system colors and a hardcoded scheme equal to the one submitted in this patch. The test tries to use all colors which have semantic bindings, like all shadows and highlights for ThreeDFace, Menu, Hightlight etc. This change will enable webdevelopers to use system colors and get an acceptable result for Safari without adding a browser specific stylesheet to their site or application. This fix relates partially to bug #6129, but deviates from the recommended colors in that testcase because the submitter apparently hadn't done any comparison on how the result in safari would compare to other browsers.
Comment 1 Peter Müller 2007-05-03 09:02:39 PDT
Created attachment 14319 [details] CSS 2.1 System color correction patch
Comment 2 Dave Hyatt 2007-05-07 22:05:52 PDT
Comment on attachment 14319 [details] CSS 2.1 System color correction patch Ultimately these should be implemented by the RenderTheme instead (system fonts are done through it, and system colors should be too).