Bug 135736 – HTML <sub> and <sup> elements do not work in some 64-bit builds

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

HTML <sub> and <sup> elements do not work in some 64-bit builds

[Simon Fraser (smfr)]

Created attachment 236244 [details]
Patch

[Tim Horton]

Comment on attachment 236244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236244&action=review

> Source/WebCore/rendering/VerticalPositionCache.h:36
>  // Values for vertical alignment.

does this comment still belong?

[alan]

Comment on attachment 236244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236244&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:942
>      // Check the cache.
>      bool isRenderInline = renderer->isRenderInline();
>      if (isRenderInline && !firstLine) {
> -        LayoutUnit verticalPosition = verticalPositionCache.get(renderer, baselineType());
> -        if (verticalPosition != PositionUndefined)
> -            return verticalPosition;
> +        LayoutUnit cachedPosition;
> +        if (verticalPositionCache.get(renderer, baselineType(), cachedPosition))
> +            return cachedPosition;
>      }
>  
>      LayoutUnit verticalPosition = 0;

RootInlineBox::verticalPositionForBox is broken in so many different ways. :(

[Simon Fraser (smfr)]

https://trac.webkit.org/r172317

[Jon Lee]

<rdar://problem/17220564>