Summary: | HTML <sub> and <sup> elements do not work in some 64-bit builds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, mmaxfield, simon.fraser, thorton, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2014-08-07 17:03:55 PDT
Created attachment 236244 [details]
Patch
Comment on attachment 236244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236244&action=review > Source/WebCore/rendering/VerticalPositionCache.h:36 > // Values for vertical alignment. does this comment still belong? Comment on attachment 236244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236244&action=review > Source/WebCore/rendering/RootInlineBox.cpp:942 > // Check the cache. > bool isRenderInline = renderer->isRenderInline(); > if (isRenderInline && !firstLine) { > - LayoutUnit verticalPosition = verticalPositionCache.get(renderer, baselineType()); > - if (verticalPosition != PositionUndefined) > - return verticalPosition; > + LayoutUnit cachedPosition; > + if (verticalPositionCache.get(renderer, baselineType(), cachedPosition)) > + return cachedPosition; > } > > LayoutUnit verticalPosition = 0; RootInlineBox::verticalPositionForBox is broken in so many different ways. :( |