Bug 135723

Summary: Web Inspector: Filter bar text and icon are positioned too low and tight
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2014-08-07 14:27:13 PDT
The position could improve.
Attachments
Patch (2.11 KB, patch)
2014-08-07 14:28 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-07 14:27:51 PDT
<rdar://problem/17950778>
Timothy Hatcher
Comment 2 2014-08-07 14:28:16 PDT
Created attachment 236222 [details] Patch
Joseph Pecoraro
Comment 3 2014-08-07 14:31:29 PDT
Comment on attachment 236222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236222&action=review r=me > Source/WebInspectorUI/UserInterface/Views/FilterBar.css:44 > + padding-top: 0; Do we need to worry about mac-platform.legacy?
Timothy Hatcher
Comment 4 2014-08-07 16:35:33 PDT
Comment on attachment 236222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236222&action=review >> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:44 >> + padding-top: 0; > > Do we need to worry about mac-platform.legacy? Nope, it is fine.
WebKit Commit Bot
Comment 5 2014-08-07 17:08:34 PDT
Comment on attachment 236222 [details] Patch Clearing flags on attachment: 236222 Committed r172312: <http://trac.webkit.org/changeset/172312>
WebKit Commit Bot
Comment 6 2014-08-07 17:08:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.