Bug 135723

Summary:

Web Inspector: Filter bar text and icon are positioned too low and tight

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Timothy Hatcher 2014-08-07 14:27:13 PDT

The position could improve.

Comment 1 Radar WebKit Bug Importer 2014-08-07 14:27:51 PDT

<rdar://problem/17950778>

Comment 2 Timothy Hatcher 2014-08-07 14:28:16 PDT

Created attachment 236222 [details]
Patch

Comment 3 Joseph Pecoraro 2014-08-07 14:31:29 PDT

Comment on attachment 236222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236222&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:44
> +    padding-top: 0;

Do we need to worry about mac-platform.legacy?

Comment 4 Timothy Hatcher 2014-08-07 16:35:33 PDT

Comment on attachment 236222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236222&action=review

>> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:44
>> +    padding-top: 0;
> 
> Do we need to worry about mac-platform.legacy?

Nope, it is fine.

Comment 5 WebKit Commit Bot 2014-08-07 17:08:34 PDT

Comment on attachment 236222 [details]
Patch

Clearing flags on attachment: 236222

Committed r172312: <http://trac.webkit.org/changeset/172312>

Comment 6 WebKit Commit Bot 2014-08-07 17:08:37 PDT

All reviewed patches have been landed.  Closing bug.