Bug 135719

Summary:

REGRESSION(169139): LLINT intermittently fails JSC testapi tests

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	ggaren: review+

Description Mark Lam 2014-08-07 13:38:21 PDT

See http://build.webkit.org/builders/Apple%20Mavericks%20LLINT%20CLoop%20%28BuildAndTest%29/builds/7450/steps/webkit-jsc-cloop-test/logs/stdio.

Maybe this is just a time out thing, but we should look into fixing the issue so that the LLINT CLoop bot is more reliable.

Comment 1 Radar WebKit Bug Importer 2014-08-07 13:39:01 PDT

<rdar://problem/17949979>

Comment 2 Mark Lam 2015-03-25 15:35:09 PDT

This is a regression introduced in http://trac.webkit.org/changeset/169139 which changed VM::watchdog from an embedded field into a std::unique_ptr, but did not update the LLINT to access it as such.

The issue has only manifested so far on the CLoop tests because those are LLINT only.  In the non-CLoop cases, the JIT kicks in and does the right thing, thereby hiding the bug in the LLINT.

Comment 3 Mark Lam 2015-03-25 16:10:12 PDT

Created attachment 249438 [details]
the patch.

Comment 4 Geoffrey Garen 2015-03-25 16:13:16 PDT

Comment on attachment 249438 [details]
the patch.

r=me

Comment 5 Mark Lam 2015-03-25 16:16:54 PDT

Thanks.  Landed in r181981: <http://trac.webkit.org/r181981>.