Bug 135716

Summary: Create UTF-8 string from in-band VTT cues
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, fpizlo, jer.noble
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2014-08-07 13:29:25 PDT
VTT cues are always UTF-8, so use String::fromUTF8().
Attachments
Proposed patch. (1.42 KB, patch)
2014-08-07 14:04 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-08-07 14:04:03 PDT
Created attachment 236219 [details] Proposed patch.
Eric Carlson
Comment 2 2014-08-07 14:05:08 PDT
Committed r172257: https://trac.webkit.org/r172257
Eric Carlson
Comment 3 2014-08-07 14:06:21 PDT
<rdar://problem/17925660>
Alexey Proskuryakov
Comment 4 2014-08-07 20:53:25 PDT
Comment on attachment 236219 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=236219&action=review > Source/WebCore/platform/graphics/ISOVTTCue.cpp:78 > + return String::fromUTF8(JSC::Uint8Array::create(data, offset, length)->data(), length); What is the reason to create a UInt8Array here? This seems much more natural to me: return String::fromUTF8(static_cast<const char*>(data->data()) + offset, length);
Note You need to log in before you can comment on or make changes to this bug.