Bug 135694

Summary: [GTK] REGRESSION(r166239): The ld version script is not being used
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 135760    
Bug Blocks:    
Attachments:
Description Flags
Patch
mrobinson: review+
Patch for landing none

Alberto Garcia
Reported 2014-08-07 01:19:19 PDT
The symbols.filter script contains the list of symbols that are local and visible outside of the webkit library. Source/cmake/OptionsGTK.cmake contains the following line: set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_SOURCE_DIR}/Source/autotools/symbols.filter") However we don't seem to be using it and that variable is not referenced anywhere else (and that's anyway the old path, it was moved to Tools/gtk when we switched to cmake).
Attachments
Patch (3.46 KB, patch)
2014-08-08 04:26 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Patch for landing (3.55 KB, patch)
2014-08-10 00:15 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-08-08 04:26:29 PDT
Created attachment 236276 [details] Patch
Carlos Garcia Campos
Comment 2 2014-08-08 11:14:43 PDT
I guess the eflsymbols.filter file is not up to date, or it's only for WebKit1, or whatever, anyway I'll add the VERSION_SCRIPT to LDFLAGS only for GTK then.
Carlos Garcia Campos
Comment 3 2014-08-10 00:15:55 PDT
Created attachment 236341 [details] Patch for landing
Carlos Garcia Campos
Comment 4 2014-08-10 00:30:52 PDT
Committed r172377: <http://trac.webkit.org/changeset/172377>
Note You need to log in before you can comment on or make changes to this bug.