| Summary: | [GTK] REGRESSION(r166239): The ld version script is not being used | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bunhere, cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, rakuco, sergio | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 135760 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 236276 [details]
Patch
I guess the eflsymbols.filter file is not up to date, or it's only for WebKit1, or whatever, anyway I'll add the VERSION_SCRIPT to LDFLAGS only for GTK then. Created attachment 236341 [details]
Patch for landing
Committed r172377: <http://trac.webkit.org/changeset/172377> |
The symbols.filter script contains the list of symbols that are local and visible outside of the webkit library. Source/cmake/OptionsGTK.cmake contains the following line: set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_SOURCE_DIR}/Source/autotools/symbols.filter") However we don't seem to be using it and that variable is not referenced anywhere else (and that's anyway the old path, it was moved to Tools/gtk when we switched to cmake).