Bug 135693

Summary: Move multicol tests into fast/regions/multicol
Product: WebKit Reporter: Iulia Tamas <iulia.tamas>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abucur, commit-queue, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Iulia Tamas
Reported 2014-08-07 00:54:21 PDT
Move multicol tests into fast/regions/multicol
Attachments
Patch (4.22 KB, patch)
2014-08-07 01:07 PDT, Iulia Tamas 		no flags
DetailsFormatted DiffDiff
Patch (7.80 KB, patch)
2014-08-07 01:10 PDT, Iulia Tamas 		no flags
DetailsFormatted DiffDiff
Patch (8.17 KB, patch)
2014-08-07 01:26 PDT, Iulia Tamas 		no flags
DetailsFormatted DiffDiff
Patch (7.76 KB, patch)
2014-08-07 04:12 PDT, Iulia Tamas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Iulia Tamas
Comment 1 2014-08-07 01:07:43 PDT
Created attachment 236178 [details] Patch
Iulia Tamas
Comment 2 2014-08-07 01:10:51 PDT
Created attachment 236179 [details] Patch
Andrei Bucur
Comment 3 2014-08-07 01:17:29 PDT
Comment on attachment 236179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236179&action=review Good patch but the changelog needs some adjustments. > LayoutTests/ChangeLog:7 > + Please add a short description of the change for people reading the logs explaining this patch moves some tests. > LayoutTests/ChangeLog:9 > + * fast/regions/multicol-as-region-prevented.html: Removed. Please list all the changed files, including the new ones.
Iulia Tamas
Comment 4 2014-08-07 01:26:54 PDT
Created attachment 236180 [details] Patch
Iulia Tamas
Comment 5 2014-08-07 04:12:20 PDT
Created attachment 236184 [details] Patch
Andrei Bucur
Comment 6 2014-08-07 04:16:24 PDT
Comment on attachment 236184 [details] Patch r=me. Congrats for the first WebKit patch! \o/
WebKit Commit Bot
Comment 7 2014-08-07 05:09:12 PDT
Comment on attachment 236184 [details] Patch Clearing flags on attachment: 236184 Committed r172207: <http://trac.webkit.org/changeset/172207>
WebKit Commit Bot
Comment 8 2014-08-07 05:09:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.