Bug 135680

Summary:

[Mac, iOS] Captions are appearing multiple times during repeated video play through

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Media

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

135332

Bug Blocks:

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Brent Fulgham 2014-08-06 17:38:12 PDT

I broke the cue comparison logic used to determine if newly encountered cues already exist in our set of cues for Generic cues (see Bug 135332 for why I did this).

Comment 1 Brent Fulgham 2014-08-06 17:38:39 PDT

<rdar://problem/17926802>

Comment 2 Brent Fulgham 2014-08-06 17:39:45 PDT

For Generic Cues (especially in these paint-on/roll-up modes) we want one set of ordering to decide which cues to render on screen first, and another for maintaining the time-ordered cue set for deciding whether a given cue is something we already know about.

Comment 3 Brent Fulgham 2014-08-06 18:25:23 PDT

Created attachment 236161 [details]
Patch

Comment 4 Eric Carlson 2014-08-06 18:35:47 PDT

Comment on attachment 236161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236161&action=review

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:218
> +bool TextTrackCueGeneric::isOrderedBeforeDuringDisplay(const TextTrackCue* that) const

As we discussed on irc, maybe "isPositionedAbove" would be clearer?

Comment 5 Brent Fulgham 2014-08-07 09:21:24 PDT

(In reply to comment #4)
> (From update of attachment 236161 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236161&action=review
> 
> > Source/WebCore/html/track/TextTrackCueGeneric.cpp:218
> > +bool TextTrackCueGeneric::isOrderedBeforeDuringDisplay(const TextTrackCue* that) const
> 
> As we discussed on irc, maybe "isPositionedAbove" would be clearer?

Will do!

Comment 6 Brent Fulgham 2014-08-07 09:23:23 PDT

Committed r172213: <http://trac.webkit.org/changeset/172213>

Comment 7 Brent Fulgham 2014-08-07 09:23:47 PDT

(In reply to comment #6)
> Committed r172213: <http://trac.webkit.org/changeset/172213>

Let's keep an eye on the Mavericks test I reactivated. If they continue to fail we can turn them back off.