Bug 135667

Summary: REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mitz, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
proposed fix andersca: review+

Description Alexey Proskuryakov 2014-08-06 13:07:28 PDT 
With WebKit1, default encoding could be set via +[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding], but there is nothing equivalent for WebKit2 modern API.
Comment 1 Alexey Proskuryakov 2014-08-06 13:07:41 PDT 
<rdar://problem/17862892>
Comment 2 Alexey Proskuryakov 2014-08-06 13:14:13 PDT 
Created attachment 236128 [details]
proposed fix
Comment 3 Anders Carlsson 2014-08-06 13:18:20 PDT 
Comment on attachment 236128 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236128&action=review

> Source/WebKit2/Shared/WebPreferencesDefinitions.h:278
> +    macro(DefaultTextEncodingName, defaultTextEncodingName, String, String, defaultTextEncodingNameForSystemLanguage()) \

I think you want to prefix this with WebCore:: since it's a WebCore function.
Comment 4 Alexey Proskuryakov 2014-08-06 13:25:51 PDT 
Committed <http://trac.webkit.org/changeset/172172>.
Comment 5 Alexey Proskuryakov 2014-08-06 13:26:12 PDT 
> I think you want to prefix this with WebCore:: since it's a WebCore function.

Talked to Anders, and we decided that it's OK as is.