Bug 135646

Summary: [GTK] Rename translation domain to WebKit2GTK-4.0
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alberto Garcia
Reported 2014-08-06 04:07:25 PDT
This needs to match the new binary version set in http://trac.webkit.org/changeset/171846
Attachments
Patch (1.20 KB, patch)
2014-08-06 04:09 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Patch (1.22 KB, patch)
2014-08-06 04:30 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2014-08-06 04:09:40 PDT
Created attachment 236090 [details] Patch
Carlos Garcia Campos
Comment 2 2014-08-06 04:12:49 PDT
Comment on attachment 236090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236090&action=review > Source/WebCore/platform/gtk/po/CMakeLists.txt:8 > -set(domain WebKit2GTK-3.0) > +set(domain WebKit2GTK-4.0) Could we use ${WEBKITGTK_API_VERSION} instead of hardcoding the version?
Alberto Garcia
Comment 3 2014-08-06 04:30:06 PDT
Created attachment 236091 [details] Patch > Could we use ${WEBKITGTK_API_VERSION} instead of hardcoding the version? You're right, here's the updated patch, I just tested it.
Carlos Garcia Campos
Comment 4 2014-08-06 05:00:55 PDT
Comment on attachment 236091 [details] Patch Perfect, thanks!
WebKit Commit Bot
Comment 5 2014-08-06 06:36:41 PDT
Comment on attachment 236091 [details] Patch Clearing flags on attachment: 236091 Committed r172142: <http://trac.webkit.org/changeset/172142>
WebKit Commit Bot
Comment 6 2014-08-06 06:36:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.