Bug 135636

Summary: Build break since r172093
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, gyuyoung.kim, laszlo.gombos, lucas.de.marchi, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 135620    
Bug Blocks:    
Attachments:
Description Flags
first trial none

Description Ryuan Choi 2014-08-05 19:27:56 PDT 
r172093 Added AbstractView.idl and CodeGeneratorJS.pm does not take care of it.

In file included from /home/ryuan/workspace/project/webkit/efl-webkit/WebKitBuild/Release/DerivedSources/WebCore/JSAbstractView.cpp:22:0:
/home/ryuan/workspace/project/webkit/efl-webkit/WebKitBuild/Release/DerivedSources/WebCore/JSAbstractView.h:24:26: fatal error: AbstractView.h: No such file or directory
 #include "AbstractView.h"
                          ^
compilation terminated.
Comment 1 Ryuan Choi 2014-08-05 19:37:13 PDT 
Created attachment 236075 [details]
first trial
Comment 2 Laszlo Gombos 2014-08-05 20:15:12 PDT 
Do we know why the try bot did not catch this ? It was green for efl-wk2 at https://bugs.webkit.org/show_bug.cgi?id=135620
Comment 3 Gyuyoung Kim 2014-08-05 20:36:37 PDT 
(In reply to comment #2)
> Do we know why the try bot did not catch this ? It was green for efl-wk2 at https://bugs.webkit.org/show_bug.cgi?id=135620

It looks efl-ews didn't generate new file because of missing to remove cache files, which was used for reducing build time. I just fixed it.
Comment 4 Gyuyoung Kim 2014-08-05 21:42:11 PDT 
Comment on attachment 236075 [details]
first trial

View in context: https://bugs.webkit.org/attachment.cgi?id=236075&action=review

rs=me to fix build break on EFL port.

> Source/WebCore/ChangeLog:3
> +        [EFL] Build break since r172093

How about using "Build break on EFL port since r172093". Because this patch modifies code generation script, and it is not EFL port specific. [EFL] prefix may cause that this patch looks like EFL specific patch.
Comment 5 Ryuan Choi 2014-08-05 22:21:06 PDT 
Committed r172128: <http://trac.webkit.org/changeset/172128>
Comment 6 Ryuan Choi 2014-08-05 22:22:47 PDT 
Comment on attachment 236075 [details]
first trial

Clearing flags after landed manually.

I am not 100% sure that this is the best.
I landed this because all bots are green and it fixes real build break.
Comment 7 Csaba Osztrogonác 2014-08-06 02:57:06 PDT 
(In reply to comment #5)
> Committed r172128: <http://trac.webkit.org/changeset/172128>

It broke the bindings-generation tests:
http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/7827