Summary: | REGRESSION (r164337): Pages are sometimes cut off/oriented incorrectly after using WKThumbnailView | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, jeffm, mitz, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2014-08-05 14:39:44 PDT
Created attachment 236051 [details]
patch
Comment on attachment 236051 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236051&action=review > Source/WebKit2/ChangeLog:48 > + Always return true from usesSnapshot; we only support snapshotting WKThumbnailViews. s/true/YES/. > Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.h:43 > +// This should be removed when all clients go away; it is always true now. Ditto. > Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.mm:161 > +// This should be removed when all clients go away; it is always true now. Ditto. |