Bug 135608

Summary: Web Inspector: ReplayManager should unpause and suppress breakpoints before capturing/replaying
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 135249    
Bug Blocks:    
Attachments:
Description Flags
Patch timothy: review+

Brian Burg
Reported 2014-08-05 09:48:44 PDT
Patch to follow.
Attachments
Patch (5.92 KB, patch)
2014-08-06 12:08 PDT, Brian Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-05 09:48:56 PDT
<rdar://problem/17917514>
Brian Burg
Comment 2 2014-08-06 12:08:23 PDT
Created attachment 236123 [details] Patch
Timothy Hatcher
Comment 3 2014-08-06 13:02:24 PDT
Comment on attachment 236123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236123&action=review > Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:682 > + WebInspector.debuggerManager.resume(); > + WebInspector.debuggerManager.addSingleFireEventListener(WebInspector.DebuggerManager.Event.Resumed, resolve); WebInspector.debuggerManager.resume() should return a Promise!
Brian Burg
Comment 4 2014-08-06 23:13:57 PDT
(In reply to comment #3) > (From update of attachment 236123 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236123&action=review > > > Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:682 > > + WebInspector.debuggerManager.resume(); > > + WebInspector.debuggerManager.addSingleFireEventListener(WebInspector.DebuggerManager.Event.Resumed, resolve); > > WebInspector.debuggerManager.resume() should return a Promise! Filed: https://bugs.webkit.org/show_bug.cgi?id=135690
Brian Burg
Comment 5 2014-08-06 23:15:09 PDT
Committed r172203: <http://trac.webkit.org/changeset/172203>
Note You need to log in before you can comment on or make changes to this bug.