Bug 135590

Summary:

Web Inspector: tree elements with depth > 1 should have context menu "expand all"/"collapse all" commands

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, graouts, hi, inspector-bugzilla-changes, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Patch	none

Brian Burg

Reported 2014-08-04 18:37:36 PDT

Some of the script profiles are ridiculously deep and there's no way to reset the state to a good starting point.

Attachments
Patch (3.35 KB, patch) 2017-01-22 12:01 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (725.67 KB, application/zip) 2017-01-22 13:02 PST, Build Bot	no flags	Details
Patch (36.58 KB, patch) 2017-01-23 00:20 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-08-04 18:37:51 PDT

<rdar://problem/17911366>

Timothy Hatcher

Comment 2 2014-08-04 19:40:33 PDT

Option-click the triangle.

Blaze Burg

Comment 3 2017-01-15 14:27:10 PST

Devin, can you add this? Should take a few minutes.

Devin Rousso

Comment 4 2017-01-22 12:01:36 PST

Created attachment 299475 [details] Patch

Build Bot

Comment 5 2017-01-22 13:02:26 PST

Comment on attachment 299475 [details] Patch Attachment 299475 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2931720 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html

Build Bot

Comment 6 2017-01-22 13:02:29 PST

Created attachment 299480 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Matt Baker

Comment 7 2017-01-22 14:08:49 PST

Comment on attachment 299475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299475&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:751 > + if (node.nodeType() === Node.ELEMENT_NODE || !node.isPseudoElement() || node.isCustomElement()) This check isn't necessary: consecutive separators are ignored by the context menu.

Timothy Hatcher

Comment 8 2017-01-22 16:14:01 PST

Comment on attachment 299475 [details] Patch This patch only addresses the DOM tree. Brian's original report was about script profiles. Though this patch seems fine too.

Devin Rousso

Comment 9 2017-01-23 00:20:23 PST

Created attachment 299508 [details] Patch

WebKit Commit Bot

Comment 10 2017-01-23 14:25:18 PST

Comment on attachment 299508 [details] Patch Clearing flags on attachment: 299508 Committed r211061: <http://trac.webkit.org/changeset/211061>

WebKit Commit Bot

Comment 11 2017-01-23 14:25:23 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.