Bug 135590

Summary:

Web Inspector: tree elements with depth > 1 should have context menu "expand all"/"collapse all" commands

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, graouts, hi, inspector-bugzilla-changes, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Patch	none

Description Brian Burg 2014-08-04 18:37:36 PDT

Some of the script profiles are ridiculously deep and there's no way to reset the state to a good starting point.

Comment 1 Radar WebKit Bug Importer 2014-08-04 18:37:51 PDT

<rdar://problem/17911366>

Comment 2 Timothy Hatcher 2014-08-04 19:40:33 PDT

Option-click the triangle.

Comment 3 BJ Burg 2017-01-15 14:27:10 PST

Devin, can you add this? Should take a few minutes.

Comment 4 Devin Rousso 2017-01-22 12:01:36 PST

Created attachment 299475 [details]
Patch

Comment 5 Build Bot 2017-01-22 13:02:26 PST

Comment on attachment 299475 [details]
Patch

Attachment 299475 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2931720

New failing tests:
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html

Comment 6 Build Bot 2017-01-22 13:02:29 PST

Created attachment 299480 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 7 Matt Baker 2017-01-22 14:08:49 PST

Comment on attachment 299475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299475&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:751
> +            if (node.nodeType() === Node.ELEMENT_NODE || !node.isPseudoElement() || node.isCustomElement())

This check isn't necessary: consecutive separators are ignored by the context menu.

Comment 8 Timothy Hatcher 2017-01-22 16:14:01 PST

Comment on attachment 299475 [details]
Patch

This patch only addresses the DOM tree. Brian's original report was about script profiles. Though this patch seems fine too.

Comment 9 Devin Rousso 2017-01-23 00:20:23 PST

Created attachment 299508 [details]
Patch

Comment 10 WebKit Commit Bot 2017-01-23 14:25:18 PST

Comment on attachment 299508 [details]
Patch

Clearing flags on attachment: 299508

Committed r211061: <http://trac.webkit.org/changeset/211061>

Comment 11 WebKit Commit Bot 2017-01-23 14:25:23 PST

All reviewed patches have been landed.  Closing bug.