| Summary: | [MSE] Further fixes for "fast forward" playback after seeking in YouTube behavior. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | calvaris, commit-queue, eric.carlson, glenn, jonlee, ltilve, philipj, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2014-08-04 13:17:12 PDT
Created attachment 235984 [details]
Patch
Comment on attachment 235984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235984&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1211 > + if (presentationTimestamp > MediaTime::createWithDouble(m_source->currentTime())) { Should this be >= instead of > ? (In reply to comment #2) > (From update of attachment 235984 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235984&action=review > > > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1211 > > + if (presentationTimestamp > MediaTime::createWithDouble(m_source->currentTime())) { > > Should this be >= instead of > ? Good point. In fact, this should probably be >, but checking against frameEndTimestamp. I.e., if the frame spans the currentTime (where the start time is <= but the end time is >), we should add the sample to the decode queue. Committed r172000: <http://trac.webkit.org/changeset/172000> Rolled out in r172007 <http://trac.webkit.org/r172007>. Re-opening. |