Bug 135571

Summary:

[GTK] run-launcher --gtk is broken

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Michael Catanzaro

Reported 2014-08-04 13:08:06 PDT

When I run layout tests, if any test fails I except MiniBrowser to be launched with test results, but instead I get this error: ScriptError raised: Failed to run "['Tools/Scripts/run-launcher', '--release', '--gtk', u'file:///home/mcatanzaro/WebKit/WebKitBuild/Release/layout-test-results/results.html']" exit_code: 2 cwd: /home/mcatanzaro/WebKit Traceback (most recent call last): File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 80, in main run_details = run(port, options, args, stderr) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 406, in run run_details = manager.run(args) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 243, in run self._port.show_results_html_file(results_path) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line 198, in show_results_html_file self._run_script("run-launcher", run_launcher_args) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1292, in _run_script output = self._executive.run_command(run_script_command, cwd=self.webkit_base(), decode_output=decode_output, env=env) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 452, in run_command (error_handler or self.default_error_handler)(script_error) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 370, in default_error_handler raise error ScriptError: Failed to run "['Tools/Scripts/run-launcher', '--release', '--gtk', u'file:///home/mcatanzaro/WebKit/WebKitBuild/Release/layout-test-results/results.html']" exit_code: 2 cwd: /home/mcatanzaro/WebKit Looks like it's looking for webkit2gtk-3.0 instead of webkit2gtk-4.0

Attachments
Patch (1.67 KB, patch) 2014-08-04 13:12 PDT, Michael Catanzaro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2014-08-04 13:12:53 PDT

Created attachment 235982 [details] Patch

WebKit Commit Bot

Comment 2 2014-08-04 19:52:12 PDT

Comment on attachment 235982 [details] Patch Clearing flags on attachment: 235982 Committed r172022: <http://trac.webkit.org/changeset/172022>

WebKit Commit Bot

Comment 3 2014-08-04 19:52:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.