Bug 135553

Summary: [EFL] Move DATA_INSTALL_DIR to ewebkit2-0
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2014-08-03 18:41:57 PDT
ewebkit used ewebkit-0 for DATA_INSTALL_DIR but libewebkit2.so and includes are installed in ewebkit2-0 Since WebKit1/Efl is dropped, we don't need to have two directory name.
Attachments
Patch (1.36 KB, patch)
2014-08-03 18:44 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.56 KB, patch)
2014-08-03 18:51 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-08-03 18:44:00 PDT
Created attachment 235955 [details] Patch
Gyuyoung Kim
Comment 2 2014-08-03 18:45:21 PDT
Comment on attachment 235955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235955&action=review > Source/cmake/OptionsEfl.cmake:41 > set(WebKit_OUTPUT_NAME ewebkit) Should we continue to keep this variable ?
Ryuan Choi
Comment 3 2014-08-03 18:51:37 PDT
Created attachment 235956 [details] Patch
Gyuyoung Kim
Comment 4 2014-08-03 18:53:38 PDT
Comment on attachment 235956 [details] Patch LGTM. But, WebKit_OUTPUT_NAME is being used by GTK port as well. Those look redundant too.
Ryuan Choi
Comment 5 2014-08-03 19:03:04 PDT
(In reply to comment #4) > (From update of attachment 235956 [details]) > LGTM. But, WebKit_OUTPUT_NAME is being used by GTK port as well. Those look redundant too. GTK port used it for DATA_BUILD_DIR but it looks also not used. I will make the different bug for GTK port maintainers to confirm it.
Ryuan Choi
Comment 6 2014-08-03 19:12:37 PDT
Comment on attachment 235956 [details] Patch Clearing flags on attachment: 235956 Committed r171985: <http://trac.webkit.org/changeset/171985>
Ryuan Choi
Comment 7 2014-08-03 19:12:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.