Summary: | [WinCairo] Compile error in OpenTypeMathData.cpp. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | peavo | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
peavo
2014-08-02 07:28:51 PDT
Created attachment 235935 [details]
Patch
Comment on attachment 235935 [details]
Patch
Thank you! R=me.
(In reply to comment #2) > (From update of attachment 235935 [details]) > Thank you! R=me. Thanks :) Just out of curiosity, are you planning to fix the WinCairo buildbot which is broken long time ago - at least a month ago. Comment on attachment 235935 [details] Patch Clearing flags on attachment: 235935 Committed r171989: <http://trac.webkit.org/changeset/171989> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Just out of curiosity, are you planning to fix the WinCairo > buildbot which is broken long time ago - at least a month ago. Haven't got access to the bot :) I believe it's just a minor issue though, I can see the following error in the build output: rm: cannot remove `/cygdrive/c/Projects/BuildSlave/win-cairo-release/build/Source/WebInspectorUI/WebInspectorUI.vcxproj': Directory not empty (In reply to comment #4) > Just out of curiosity, are you planning to fix the WinCairo > buildbot which is broken long time ago - at least a month ago. That is a known problem, and the maintainers said they will fix it. It seems to be a low priority, though. I might set up one I have more control over in about a month. WinCairo is not dead. |