Bug 135536

Summary: [iOS] WebKit links against libraries it doesn’t use
Product: WebKit Reporter: mitz
Component: New BugsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Stop linking against two unused libraries thorton: review+

Description mitz 2014-08-01 21:56:27 PDT
<rdar://problem/17891752>

WebKit doesn’t use any symbols from MobileAsset.framework and libassertion_extension.dylib.
Comment 1 mitz 2014-08-01 22:15:41 PDT
Created attachment 235931 [details]
Stop linking against two unused libraries
Comment 2 Tim Horton 2014-08-01 22:22:33 PDT
Comment on attachment 235931 [details]
Stop linking against two unused libraries

View in context: https://bugs.webkit.org/attachment.cgi?id=235931&action=review

> Source/WebKit2/Configurations/WebKit.xcconfig:-33
> -FRAMEWORK_AND_LIBRARY_LDFLAGS_iphonesimulator = -lobjc -framework AssertionServices -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework CorePDF -framework CoreText -framework Foundation -framework GraphicsServices -framework ImageIO -framework UIKit -framework OpenGLES -framework MobileAsset -framework MobileCoreServices -lMobileGestalt -lassertion_extension;

WebKitLegacy.xcconfig has MobileAsset as well; should it be removed from there?
Comment 3 mitz 2014-08-01 22:26:14 PDT
(In reply to comment #2)
> (From update of attachment 235931 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235931&action=review
> 
> > Source/WebKit2/Configurations/WebKit.xcconfig:-33
> > -FRAMEWORK_AND_LIBRARY_LDFLAGS_iphonesimulator = -lobjc -framework AssertionServices -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework CorePDF -framework CoreText -framework Foundation -framework GraphicsServices -framework ImageIO -framework UIKit -framework OpenGLES -framework MobileAsset -framework MobileCoreServices -lMobileGestalt -lassertion_extension;
> 
> WebKitLegacy.xcconfig has MobileAsset as well; should it be removed from there?

Good catch! I think it can be removed safely from there as well.
Comment 4 mitz 2014-08-01 23:07:31 PDT
Fixed in <http://trac.webkit.org/r171965>.