Bug 135535

Summary: Add a flag for the CSS Selectors level 4 implementation
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, kling, rakuco, sergio, syoichi, ysuzuki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2014-08-01 21:38:39 PDT
Add a flag for the CSS Selectors level 4 implementation
Attachments
Patch (34.76 KB, patch)
2014-08-01 21:40 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (39.61 KB, patch)
2014-08-02 14:01 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-08-01 21:40:09 PDT
Created attachment 235929 [details] Patch
Csaba Osztrogonác
Comment 2 2014-08-02 12:36:44 PDT
Comment on attachment 235929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235929&action=review > WebKitLibraries/win/tools/vsprops/FeatureDefines.props:19 > + <ENABLE_CSS_REGIONS>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_REGIONS> copy/paste error
Csaba Osztrogonác
Comment 3 2014-08-02 12:39:37 PDT
Comment on attachment 235929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235929&action=review >> WebKitLibraries/win/tools/vsprops/FeatureDefines.props:19 >> + <ENABLE_CSS_REGIONS>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_REGIONS> > > copy/paste error And maybe you should add it one more place below in this file.
Benjamin Poulain
Comment 4 2014-08-02 14:01:58 PDT
Created attachment 235939 [details] Patch
Benjamin Poulain
Comment 5 2014-08-02 14:04:29 PDT
(In reply to comment #3) > >> WebKitLibraries/win/tools/vsprops/FeatureDefines.props:19 > >> + <ENABLE_CSS_REGIONS>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_REGIONS> > > > > copy/paste error > > And maybe you should add it one more place below in this file. Yup, yup, yup, good catch. I have updated the patch, hopefully good with Windows this time.
Gyuyoung Kim
Comment 6 2014-08-03 19:23:35 PDT
EFL ews failure looks false alarm.
Benjamin Poulain
Comment 7 2014-08-04 20:39:58 PDT
Comment on attachment 235939 [details] Patch Clearing flags on attachment: 235939 Committed r172023: <http://trac.webkit.org/changeset/172023>
Benjamin Poulain
Comment 8 2014-08-04 20:40:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.