| Summary: | Add a flag for the CSS Selectors level 4 implementation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bunhere, commit-queue, gyuyoung.kim, kling, rakuco, sergio, syoichi, ysuzuki | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2014-08-01 21:38:39 PDT
Created attachment 235929 [details]
Patch
Comment on attachment 235929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235929&action=review > WebKitLibraries/win/tools/vsprops/FeatureDefines.props:19 > + <ENABLE_CSS_REGIONS>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_REGIONS> copy/paste error Comment on attachment 235929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235929&action=review >> WebKitLibraries/win/tools/vsprops/FeatureDefines.props:19 >> + <ENABLE_CSS_REGIONS>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_REGIONS> > > copy/paste error And maybe you should add it one more place below in this file. Created attachment 235939 [details]
Patch
(In reply to comment #3) > >> WebKitLibraries/win/tools/vsprops/FeatureDefines.props:19 > >> + <ENABLE_CSS_REGIONS>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_REGIONS> > > > > copy/paste error > > And maybe you should add it one more place below in this file. Yup, yup, yup, good catch. I have updated the patch, hopefully good with Windows this time. EFL ews failure looks false alarm. Comment on attachment 235939 [details] Patch Clearing flags on attachment: 235939 Committed r172023: <http://trac.webkit.org/changeset/172023> All reviewed patches have been landed. Closing bug. |