Bug 135527

Summary:

commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes

Product:

WebKit

Reporter:

mitz

Component:

Tools / Tests

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Apply commit message formatting to prepared ChangeLog entries	thorton: review+

mitz

Reported 2014-08-01 15:55:40 PDT

In a git repository, if the git index contains no changes to ChanegLog files, commit-log-editor prepares a commit message that is straight prepare-ChangeLog output, including 8-space indentation and date + author headers.

Attachments
Apply commit message formatting to prepared ChangeLog entries (12.70 KB, patch) 2014-08-01 16:05 PDT, mitz	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2014-08-01 16:05:23 PDT

Created attachment 235918 [details] Apply commit message formatting to prepared ChangeLog entries

Tim Horton

Comment 2 2014-08-01 16:06:57 PDT

Comment on attachment 235918 [details] Apply commit message formatting to prepared ChangeLog entries View in context: https://bugs.webkit.org/attachment.cgi?id=235918&action=review > Tools/ChangeLog:10 > + the --delimiters option the prepare-ChangeLog, then process each entry in the output using s/the/to/?

mitz

Comment 3 2014-08-01 16:10:36 PDT

(In reply to comment #2) > (From update of attachment 235918 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235918&action=review > > > Tools/ChangeLog:10 > > + the --delimiters option the prepare-ChangeLog, then process each entry in the output using > > s/the/to/? Yes!

mitz

Comment 4 2014-08-01 16:11:21 PDT

Fixed in <http://trac.webkit.org/r171954>.

Note You need to log in before you can comment on or make changes to this bug.