Summary: | Support both window and view based video fullscreen. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||
Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, jer.noble, jonlee, philipj, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jeremy Jones
2014-08-01 15:45:29 PDT
Created attachment 235921 [details]
Patch
Attachment 235921 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:913: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 235921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235921&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:67 > RetainPtr<UIViewController> m_viewController; > + RetainPtr<UIWindow> m_window; > + RetainPtr<UIView> m_parentView; Please add a comment or two here explaining which of these are used in which cases. > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:750 > + if (![bundleIdentifier isEqualToString:@"com.apple.AdSheetPhone"]) { You should not bury this application check here. Please add it to RuntimeApplicationCheckIOS.mm and use !applicationIsAdSheet() here. I think it's worth referencing a radar in a comment too. Comment on attachment 235921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235921&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:857 > + [m_window setHidden:YES]; > + [m_window setRootViewController:nil]; Nit: you nil-check m_window below so you might as well put these in that block. Created attachment 235941 [details]
Patch for landing.
(In reply to comment #5) > (From update of attachment 235921 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235921&action=review > > > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:857 > > + [m_window setHidden:YES]; > > + [m_window setRootViewController:nil]; > > Nit: you nil-check m_window below so you might as well put these in that block. Done. (In reply to comment #4) > (From update of attachment 235921 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235921&action=review > > > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:67 > > RetainPtr<UIViewController> m_viewController; > > + RetainPtr<UIWindow> m_window; > > + RetainPtr<UIView> m_parentView; > > Please add a comment or two here explaining which of these are used in which cases. Grouped them and added a comment. > > > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:750 > > + if (![bundleIdentifier isEqualToString:@"com.apple.AdSheetPhone"]) { > > You should not bury this application check here. Please add it to RuntimeApplicationCheckIOS.mm and use !applicationIsAdSheet() here. I think it's worth referencing a radar in a comment too. Done. Attachment 235941 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:910: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 235941 [details] Patch for landing. Clearing flags on attachment: 235941 Committed r171973: <http://trac.webkit.org/changeset/171973> |