Bug 135519

Summary:

Many DOM objects have InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero for no reason.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Bindings

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cgarcia, commit-queue, ggaren, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2014-08-01 14:42:36 PDT

We shouldn't set this structure flag for DOM objects that don't even intercept getOwnPropertySlotByIndex.

Comment 1 Andreas Kling 2014-08-01 14:43:59 PDT

Created attachment 235904 [details]
Patch

Comment 2 Geoffrey Garen 2014-08-01 15:24:35 PDT

Comment on attachment 235904 [details]
Patch

r=me

Does this make a benchmark or some other test case faster?

Comment 3 Andreas Kling 2014-08-01 15:47:33 PDT

(In reply to comment #2)
> (From update of attachment 235904 [details])
> r=me
> 
> Does this make a benchmark or some other test case faster?

None that I know of. We could make one.

Comment 4 WebKit Commit Bot 2014-08-01 16:21:03 PDT

Comment on attachment 235904 [details]
Patch

Clearing flags on attachment: 235904

Committed r171956: <http://trac.webkit.org/changeset/171956>

Comment 5 WebKit Commit Bot 2014-08-01 16:21:08 PDT

All reviewed patches have been landed.  Closing bug.