Summary: | [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mrobinson, pnormand | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-08-01 04:12:24 PDT
It seems it's trying to convert ascii text to utf8, but the text is not ascii, but utf8 already. This line is causing the problem: html/WebKitContextMenuItem.html:200: warning: no link for: 'GtkAction-activate' -> (<span class="type">“activate”</span>). Because of the quotation marks in “activate”. The line crashing is: sys.stdout.write(stdout.encode("utf-8")) and it works if we just remove the encode sys.stdout.write(stdout) I guess the output should be decoded as utf-8? (In reply to comment #2) > I guess the output should be decoded as utf-8? I think we should simply remove all .encode('utf-8') Created attachment 236582 [details]
Patch
I think Martin is right, decode should be used. (In reply to comment #5) > I think Martin is right, decode should be used. I don't see why we need to mess up with stdout/stderr encoding, what we get from the command is what we send to stderr/stdout Created attachment 238649 [details]
This should work for everybody
Committed r174309: <http://trac.webkit.org/changeset/174309> |