Bug 135501

Summary: [CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bunhere, cdumez, commit-queue, gustavo, gyuyoung.kim, mrobinson, rakuco, sergio
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gyuyoung.kim: review+

Carlos Garcia Campos
Reported 2014-08-01 04:05:38 PDT
It should be PROJECT_VERSION_MICRO instead.
Attachments
Patch (4.64 KB, patch)
2014-08-01 04:07 PDT, Carlos Garcia Campos 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-08-01 04:07:58 PDT
Created attachment 235884 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-01 04:08:52 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gyuyoung Kim
Comment 3 2014-08-01 05:36:19 PDT
Comment on attachment 235884 [details] Patch LGTM
Carlos Garcia Campos
Comment 4 2014-08-01 06:35:22 PDT
Committed r171915: <http://trac.webkit.org/changeset/171915>
Martin Robinson
Comment 5 2014-08-01 11:26:48 PDT
Comment on attachment 235884 [details] Patch Nice catch!
Note You need to log in before you can comment on or make changes to this bug.