Bug 135499

Summary: Make it easer to add switches to MiniBrowser
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2014-08-01 01:32:59 PDT
Put all of the settings in one place, share more code between WK{1,2}BrowserWindowController; make them all persistent and as global as they can be.
Attachments
patch (43.65 KB, patch)
2014-08-01 01:52 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-08-01 01:52:29 PDT
Created attachment 235882 [details] patch
WebKit Commit Bot
Comment 2 2014-08-01 01:53:41 PDT
Attachment 235882 [details] did not pass style-queue: ERROR: Tools/MiniBrowser/mac/SettingsController.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-08-01 11:21:51 PDT
http://trac.webkit.org/changeset/171926
Note You need to log in before you can comment on or make changes to this bug.