Bug 135490

Summary: Web Inspector: "Stop Recording" button feels unresponsive, recording takes a long time to stop
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-07-31 18:59:32 PDT
We recently changed "Stop Recording" button to wait for a "recordingStopped" event from the backend to stop. However, this can produce a very large delay between the time the user clicked "Stop Recording" to when the frontend gets the event. This is especially bad in remote debugging, e.g. with iOS.

We should have the UI immediately stop recording and ignore future events. This was the behavior before r171195.

1. Load <http://apple.com> in remote target
2. Inspect remote target
3. Reload via inspector
4. Quickly click the record button to "Stop Recording"
  => recording continues for a couple seconds

Comment 1 Joseph Pecoraro 2014-07-31 19:02:13 PDT
Created attachment 235870 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2014-07-31 20:34:53 PDT
Comment on attachment 235870 [details]
[PATCH] Proposed Fix

Good call.
Comment 3 WebKit Commit Bot 2014-07-31 21:07:26 PDT
Comment on attachment 235870 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 235870

Committed r171908: <http://trac.webkit.org/changeset/171908>
Comment 4 WebKit Commit Bot 2014-07-31 21:07:29 PDT
All reviewed patches have been landed.  Closing bug.