Bug 135488

Summary: [Media iOS] Ensure there is a nice default fallback for missing wireless target names
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Dean Jackson
Reported 2014-07-31 18:16:31 PDT
[Media iOS] Ensure there is a nice default fallback for missing wireless target names
Attachments
Patch (2.61 KB, patch)
2014-07-31 18:26 PDT, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-07-31 18:18:11 PDT
We occasionally run into cases where this.host.externalDeviceDisplayName is empty or null, creating a pretty ugly/confusing string in the wireless playback status screen. If this happens, we should default to using "AppleTV" <rdar://problem/17879156>
Dean Jackson
Comment 2 2014-07-31 18:26:28 PDT
Created attachment 235868 [details] Patch
Eric Carlson
Comment 3 2014-07-31 21:45:00 PDT
Comment on attachment 235868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235868&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:113 > + var externalDeviceDisplayName = (this.host.externalDeviceDisplayName && this.host.externalDeviceDisplayName != "") ? this.host.externalDeviceDisplayName : "AppleTV"; Nit: this would be slightly easier to understand if it was split into two separate lines: var externalDeviceDisplayName = this.host.externalDeviceDisplayName; If (...)
Dean Jackson
Comment 4 2014-08-01 12:42:44 PDT
Committed r171944: <http://trac.webkit.org/changeset/171944>
Note You need to log in before you can comment on or make changes to this bug.