Bug 135482

Summary:

MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Brent Fulgham 2014-07-31 17:02:41 PDT

You cannot enter Fullscreen mode for videos in a MiniBrowser WebKit2 window. This should be fixed!

Comment 1 Brent Fulgham 2014-07-31 17:08:31 PDT

Created attachment 235861 [details]
Patch

Comment 2 Tim Horton 2014-07-31 17:15:07 PDT

Comment on attachment 235861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235861&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:53
> +@property (nonatomic, setter=_setFullScreenEnabled:) BOOL _fullScreenIsEnabled;

no is plz

Comment 3 Brent Fulgham 2014-07-31 17:41:12 PDT

Landed in two patches:

Committed r171897 <http://trac.webkit.org/changeset/171897>.
Committed r171899 <http://trac.webkit.org/changeset/171899>.

Comment 4 Brent Fulgham 2014-07-31 17:51:55 PDT

One more -- i forgot to fix MinIBrowser itself:

Committed r171900 <http://trac.webkit.org/changeset/171900>.