Bug 135464

Summary: [Win] Fix build failure when using 5-tuple build versions
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ddkilzer, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch ddkilzer: review+

Brent Fulgham
Reported 2014-07-31 10:38:31 PDT
The VersionStamper tool throws an exception when the RC_PROJECTSOURCEVERSION environment variable contains more than three tuples, even when specific build arguments are given to it. To avoid the problem, temporarily set the RC_PROJECTSOURCEVERSION, RC_ProjectSourceVersion, and RC_PROJECTBUILDVERSION environment variables to safe/valid 3-tuple versions of the 5-tuple information before invoking the version stamping tool.
Attachments
Patch (1.99 KB, patch)
2014-07-31 10:42 PDT, Brent Fulgham 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-07-31 10:39:05 PDT
Tested on builds with invalid RC_PROJECTSOURCEVERSION, RC_ProjectSourceVersion, and RC_PROJECTBUILDVERSION environment variables set.
Brent Fulgham
Comment 2 2014-07-31 10:42:37 PDT
Created attachment 235830 [details] Patch
Radar WebKit Bug Importer
Comment 3 2014-07-31 10:44:28 PDT
<rdar://problem/17872457>
Radar WebKit Bug Importer
Comment 4 2014-07-31 10:46:18 PDT
<rdar://problem/17872507>
David Kilzer (:ddkilzer)
Comment 5 2014-07-31 10:53:18 PDT
Comment on attachment 235830 [details] Patch r=me
Brent Fulgham
Comment 6 2014-07-31 11:01:09 PDT
Committed r171870: <http://trac.webkit.org/changeset/171870>
Note You need to log in before you can comment on or make changes to this bug.