Bug 135464

Summary: [Win] Fix build failure when using 5-tuple build versions
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ddkilzer, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch ddkilzer: review+

Description Brent Fulgham 2014-07-31 10:38:31 PDT 
The VersionStamper tool throws an exception when the RC_PROJECTSOURCEVERSION environment variable contains more than three tuples, even when specific build arguments are given to it.

To avoid the problem, temporarily set the RC_PROJECTSOURCEVERSION, RC_ProjectSourceVersion, and RC_PROJECTBUILDVERSION environment variables to safe/valid 3-tuple versions of the 5-tuple information before invoking the version stamping tool.
Comment 1 Brent Fulgham 2014-07-31 10:39:05 PDT 
Tested on builds with invalid RC_PROJECTSOURCEVERSION, RC_ProjectSourceVersion, and RC_PROJECTBUILDVERSION environment variables set.
Comment 2 Brent Fulgham 2014-07-31 10:42:37 PDT 
Created attachment 235830 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2014-07-31 10:44:28 PDT 
<rdar://problem/17872457>
Comment 4 Radar WebKit Bug Importer 2014-07-31 10:46:18 PDT 
<rdar://problem/17872507>
Comment 5 David Kilzer (:ddkilzer) 2014-07-31 10:53:18 PDT 
Comment on attachment 235830 [details]
Patch

r=me
Comment 6 Brent Fulgham 2014-07-31 11:01:09 PDT 
Committed r171870: <http://trac.webkit.org/changeset/171870>