Bug 135462

Summary:

Fix resource leak in FillLayersPropertyWrapper object member

Product:

WebKit

Reporter:

przemeks@pkuczynski.com <p.kuczynski>

Component:

WebCore Misc.

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, dstockwell, m.leszko, mpakulavelrutka, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
porposed patch	none
Patch	none

Description przemeks@pkuczynski.com 2014-07-31 06:51:33 PDT

Despite allocating memory in constructor, m_fillLayerPropertyWrapper is never freed
causing memory leak.

Comment 1 przemeks@pkuczynski.com 2014-07-31 06:53:35 PDT

Created attachment 235827 [details]
porposed patch

Comment 2 Simon Fraser (smfr) 2014-07-31 08:43:18 PDT

Comment on attachment 235827 [details]
porposed patch

This should use std::unique_ptr<>

Comment 3 Simon Fraser (smfr) 2014-08-01 11:50:05 PDT

Created attachment 235897 [details]
Patch

Comment 4 WebKit Commit Bot 2014-08-01 17:00:43 PDT

Comment on attachment 235897 [details]
Patch

Clearing flags on attachment: 235897

Committed r171960: <http://trac.webkit.org/changeset/171960>

Comment 5 WebKit Commit Bot 2014-08-01 17:00:50 PDT

All reviewed patches have been landed.  Closing bug.