| Summary: | [EFL] remove ewk_defines.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryuan Choi
2014-07-31 04:43:18 PDT
Created attachment 235818 [details]
Patch
Comment on attachment 235818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235818&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] remove ewk_defines.h IIRC, ewk_defines.h was added because there was circular include chain problem in ewk. Is there no the problem now ? (In reply to comment #2) > (From update of attachment 235818 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235818&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL] remove ewk_defines.h > > IIRC, ewk_defines.h was added because there was circular include chain problem in ewk. Is there no the problem now ? right, there are circular include issue because both ewk_context_menu.h and ewk_context_menu_item.h requires Ewk_Context_Menu and Ewk_Context_Menu_Item. In order to avoid it, this patch just declares them to ewk_context_menu_item.h and let ewk_context.h include ewk_context_menu.h instead of using ewk_defines.h. Comment on attachment 235818 [details] Patch Clearing flags on attachment: 235818 Committed r171901: <http://trac.webkit.org/changeset/171901> All reviewed patches have been landed. Closing bug. |