| Summary: | [EFL] Add support for building with Geoclue2 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WebKit EFL | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | benjamin, buildbot, bunhere, commit-queue, gyuyoung.kim, lucas.de.marchi, ossy, rakuco, rniwa, sergio, tonikitoo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
Carlos Alberto Lopez Perez
2014-07-31 04:21:44 PDT
Created attachment 235814 [details]
Build failure because of missing derived sources
Created attachment 235815 [details]
After fixing the derived source issue, there is a second build failure due to missing includes.
Created attachment 235817 [details]
Patch
Comment on attachment 235817 [details] Patch Attachment 235817 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6386066789498880 New failing tests: media/track/add-and-remove-track.html Created attachment 235820 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 235817 [details] Patch Attachment 235817 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4906511759310848 New failing tests: media/track/add-and-remove-track.html Created attachment 235822 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Cleared r- flag (Is just impossible that this has caused a failure on the layout test media/track/add-and-remove-track.html of the mac port. That should be some flaky test not marked as such) (In reply to comment #8) > Cleared r- flag (Is just impossible that this has caused a failure on the layout test media/track/add-and-remove-track.html of the mac port. That should be some flaky test not marked as such) Mac WK2 EWS is very flakey nowadays, see the webkit-dev thread for details. Comment on attachment 235817 [details]
Patch
LGTM. Thanks.
Comment on attachment 235817 [details] Patch Clearing flags on attachment: 235817 Committed r171904: <http://trac.webkit.org/changeset/171904> All reviewed patches have been landed. Closing bug. |