| Summary: | REGRESSION: Animations inside RTL multicolumn content is broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | abucur, dino, hyatt, koivisto, mihnea, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2014-07-30 23:13:53 PDT
Created attachment 235809 [details]
Test case
See how "hello" moves between two locations but it shouldn't.
It should always show up on the right of "world".
This one appears to be caused by accumulateOffsetTowardsAncestor adding the offset in:
RenderRegion* region = toRenderMultiColumnFlowThread(parentLayer->renderer()).physicalTranslationFromFlowToRegion(location);
if (region)
location.moveBy(region->topLeftLocation() + -parentLayer->renderBox()->topLeftLocation());
Removing the last two lines here fixes the bug.
It's curious how RenderBoxModelObject::adjustedPositionRelativeToOffsetParent has a very similar code:
RenderRegion* region = toRenderMultiColumnFlowThread(curr)->physicalTranslationFromFlowToRegion(referencePoint);
if (region)
referencePoint.moveBy(region->topLeftLocation());
Isn't this just all RenderLayer content, even without animation? I thought you had an example with opacity. This bug has the same cause as https://bugs.webkit.org/show_bug.cgi?id=135452. Confirmed fixed with http://trac.webkit.org/changeset/171882. Thanks! *** This bug has been marked as a duplicate of bug 135452 *** |